Dealing with existant VPC for IdeficsInterface deployment #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2024 10:11
…ch automatically by vpc lookup
…ch automatically by vpc lookup
bigadsoleiman
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
since release version 4.0.3 it seems there is condition disappeared for Idefics Interface activation or not.
You can compare this latest version with previous one like v4.0.3 at the same line :
aws-genai-llm-chatbot/lib/aws-genai-llm-chatbot-stack.ts
Line 110 in 3c710bf
is it normal or a mistake ? In my case I cannot not deploy anymore due this new resource not available before and it need a default security group ID for private VPC endpoint.
This happened when VPC already exist, it seems the method "ec2.Vpc.fromLookup" does not detect a default security group.
Here the impact :
https://github.com/aws-samples/aws-genai-llm-chatbot/blob/main/lib/model-interfaces/idefics/index.ts#L41
This property "props.shared.vpc.vpcDefaultSecurityGroup" should contains a default security group ID.
For an existing VPC this value seems to be blank.
This condition impact also ResourcePath for NagSuppressions.
Best regards,